Refactor: SAA 마이그레이션 #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanubc
reviewed
May 13, 2024
Contributor
chanubc
left a comment
chanubc
left a comment
There was a problem hiding this comment.
start destination이랑
이에따른 stack 관리 코드 설정해 주시면 될것 같습니다!
popUpTo이나 popUpToInclusive이런거요!
Eonji-sw
reviewed
May 14, 2024
Member
Eonji-sw
left a comment
Eonji-sw
left a comment
There was a problem hiding this comment.
우옹 세미나 과제에 ssa 적용해볼까 생각하고 있는데 참고해서 해봐야겠네용 졸프라고 들었는데 고생하셨어요! 저도 이제야 PR 올린 ㅎ..
chanubc
reviewed
May 14, 2024
| (supportFragmentManager.findFragmentById(R.id.fcv_home) as NavHostFragment) | ||
| .findNavController() | ||
| binding.bnvHome.setupWithNavController(navController) | ||
| navController.navigate(R.id.fragment_login) |
Contributor
There was a problem hiding this comment.
MainActivity에서 자동로그인 여부를 판단하고 로그인 화면으로 넘기는게 나을 것 같습니다!
지금은 무조건 로그인으로 넘어가고 로그인에서 자동로그인 여부를 판단하는데 불필요한 작업인것 같아서요!
로그인에서 옵저빙 하는 코드를 그대로 메인액티비티로 옮기시면 될것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
[로그인-회원가입-홈 플로우 영상]
https://github.com/NOWSOPT34-Advanced-Study/Team3/assets/114990782/c7250434-7bf4-40f9-951f-89945705c5e3
Screen_recording_20240513_143714.webm
[마이페이지-회원탈퇴-로그인 플로우 영상]
Screen_recording_20240513_143714.webm
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴